Skip to content

Conversation

@mahajantejas
Copy link
Collaborator

@mahajantejas mahajantejas commented Oct 7, 2025

Summary by CodeRabbit

  • Documentation
    • Added a leading placeholder line ("___") to the Link Google Sheets documentation to improve formatting; no changes to instructions or examples.

@mahajantejas mahajantejas requested a review from Fawas003 October 7, 2025 10:47
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Inserted a single leading placeholder line ("___") before the existing header structure in the Link Google Sheets documentation file; no content or logic changes were made.

Changes

Cohort / File(s) Summary
Docs: Link Google Sheets (formatting)
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
Added a leading placeholder line ___ before the existing headers (purely formatting/markup change; no content or logic modifications).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • SangeetaMishr
  • Fawas003

Poem

A tiny hop across the sheet,
I tuck a line where headers meet.
No logic changed, just tidy cheer,
A rabbit's mark to keep things clear. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the primary change by stating that the expression for sending HSM templates via Google Sheets has been corrected, directly reflecting the updates made in the documentation and providing clear context for reviewers scanning the history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfbfedf and a67202c.

📒 Files selected for processing (1)
  • docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

@github-actions github-actions bot temporarily deployed to pull request October 7, 2025 10:49 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fef017f and bfbfedf.

📒 Files selected for processing (1)
  • docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md (1 hunks)

Comment on lines 97 to 100
5. In the next step, `Send contact a message` is used and an expression is given in place of the template selection drop-down. The expression to be added for the HSM templates which contain template variables is as follows `<%= Glific.send_template("@results.sheet.template_uuid", ["@contact.name","@contact.fields.district"] ) %>`. The variables can be added in the square brackets inside double quotes separated by commas. Refer to how @contact.name, @contact.fields.district have been added. Different contact variables or just plain strings can be added as variables.

6. For HSM templates without any template variables, the following expression can be used `<%= Glific.send_template("@results.sheet.template_uuid", [] ) %>`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Unquoted variables are required inside Glific.send_template.

Quoting @results.sheet.template_uuid, @contact.name, etc. turns them into literal strings, so the sent template will show @contact.name instead of the contact’s actual name. Drop the quotes so the helper receives evaluated values.

-… `<%= Glific.send_template("@results.sheet.template_uuid", ["@contact.name","@contact.fields.district"] ) %>` …
+… `<%= Glific.send_template(@results.sheet.template_uuid, [@contact.name, @contact.fields.district]) %>` …
-6. For HSM templates without any template variables, the following expression can be used  `<%= Glific.send_template("@results.sheet.template_uuid", [] ) %>`
+6. For HSM templates without any template variables, the following expression can be used  `<%= Glific.send_template(@results.sheet.template_uuid, []) %>`
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
5. In the next step, `Send contact a message` is used and an expression is given in place of the template selection drop-down. The expression to be added for the HSM templates which contain template variables is as follows `<%= Glific.send_template("@results.sheet.template_uuid", ["@contact.name","@contact.fields.district"] ) %>`. The variables can be added in the square brackets inside double quotes separated by commas. Refer to how @contact.name, @contact.fields.district have been added. Different contact variables or just plain strings can be added as variables.
6. For HSM templates without any template variables, the following expression can be used `<%= Glific.send_template("@results.sheet.template_uuid", [] ) %>`
5. In the next step, `Send contact a message` is used and an expression is given in place of the template selection drop-down. The expression to be added for the HSM templates which contain template variables is as follows `<%= Glific.send_template(@results.sheet.template_uuid, [@contact.name, @contact.fields.district]) %>`. The variables can be added in the square brackets separated by commas. Refer to how @contact.name and @contact.fields.district have been added. Different contact variables or just plain strings can be added as variables.
6. For HSM templates without any template variables, the following expression can be used `<%= Glific.send_template(@results.sheet.template_uuid, []) %>`
🤖 Prompt for AI Agents
In docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
around lines 97 to 100, the examples incorrectly show quoted variables inside
the Glific.send_template call which causes them to be sent as literal text;
update the examples to remove the quotes so the helper receives evaluated values
(i.e., pass @results.sheet.template_uuid and contact variables like
@contact.name or @contact.fields.district unquoted, and keep an empty array for
templates without variables).

Copy link
Contributor

@Fawas003 Fawas003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Level, last updated and time required details are missing in this doc. Could you please add that.

@SangeetaMishr
Copy link
Collaborator

@mahajantejas Actions are pending on this PR, can you please take a look at it.

@mahajantejas mahajantejas merged commit 4ec2f42 into main Oct 24, 2025
5 of 6 checks passed
@mahajantejas mahajantejas deleted the correcting-expression-for-hsmtemplates-from-googlesheets branch October 24, 2025 08:39
@github-actions github-actions bot temporarily deployed to pull request October 24, 2025 08:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants