-
Notifications
You must be signed in to change notification settings - Fork 9
Update 12. Link Google Sheets.md #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
changed expression added steps and more explaintion
|
Warning Rate limit exceeded@SangeetaMishr has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 16 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe "Link Google Sheets" documentation was restructured: a new HTML header block was added; the content was expanded and reorganized to cover Readable and Writable Google Sheets, setup steps, examples, UI terminology updates, standardized Glific expressions, and clarified @results.sheet.* usage and flow steps. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User as User
participant Flow as Flow (Glific)
participant GSheets as Google Sheets API
rect rgb(240,248,255)
note over Flow,GSheets: Readable Google Sheet (fetch options)
User->>Flow: Trigger flow that reads sheet
Flow->>GSheets: Fetch rows (key/filters)
GSheets-->>Flow: Return rows (values, keys)
Flow->>User: Send interactive message (options from sheet)
User-->>Flow: Respond / select option
Flow->>Flow: Populate variables (e.g., @results.sheet.*)
end
rect rgb(245,255,240)
note over Flow,GSheets: Writable Google Sheet (append/update)
User->>Flow: Provide input data
Flow->>GSheets: Append or update row with variables
GSheets-->>Flow: Return write result (status, row id)
Flow->>User: Acknowledge / continue flow
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md (1)
64-64: Promote “Examples” labels to proper headings.Markdownlint flagged the bold text used as a heading. Converting the emphasized “Examples” lines to real headings (e.g.,
#### Examples) clears MD036 and keeps the structure consistent.Also applies to: 118-118
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md(6 hunks)
🧰 Additional context used
🪛 GitHub Actions: Build and Deploy to Netlify
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
[error] 147-147: MDX compilation failed during build. Unexpected character '%' (U+0025) before name in MDX file. Details: Unexpected character % before name, expected a character that can start a name (line 147, column 150). Command: yarn build (Docusaurus build).
🪛 GitHub Actions: Test deployment
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
[error] 147-147: MDX compilation failed during 'yarn build'. Unexpected character '%' (U+0025) before name, expected a character that can start a name (line 147, column 150).
🪛 markdownlint-cli2 (0.18.1)
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
64-64: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
118-118: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
| 5. In the next step, `Send contact a message` is used and an expression is given in place of the template selection drop-down. The expression reads <%= `Glific.send_template("@results.sheet.template_uuid", ["@contact.name"] ) %>` and if no variables then `<%= Glific.send_template("@results.sheet.template_uuid", [] ) %>` | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix MDX parse failure around <%= expressions.
The inline <%= snippets are parsed as JSX, causing the MDX build to abort (Unexpected character '%' ... line 147). Wrap those expressions in code fences or escape the < so the compiler treats them as plain text. Example fix:
-5. ... The expression reads <%= `Glific.send_template("@results.sheet.template_uuid", ["@contact.name"] ) %>` and if no variables then `<%= Glific.send_template("@results.sheet.template_uuid", [] ) %>`
+5. ... The expression reads:
+
+```elixir
+<%= Glific.send_template("@results.sheet.template_uuid", ["@contact.name"]) %>
+```
+
+If no variables are required, use:
+
+```elixir
+<%= Glific.send_template("@results.sheet.template_uuid", []) %>
+```🧰 Tools
🪛 GitHub Actions: Build and Deploy to Netlify
[error] 147-147: MDX compilation failed during build. Unexpected character '%' (U+0025) before name in MDX file. Details: Unexpected character % before name, expected a character that can start a name (line 147, column 150). Command: yarn build (Docusaurus build).
🪛 GitHub Actions: Test deployment
[error] 147-147: MDX compilation failed during 'yarn build'. Unexpected character '%' (U+0025) before name, expected a character that can start a name (line 147, column 150).
🤖 Prompt for AI Agents
In docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
around lines 147-149, the inline ERB-style snippets like <%= ... %> are being
parsed as JSX/MDX and causing a build error; wrap those expressions in code
fences or escape the opening '<' so the MDX compiler treats them as literal
text. Replace the inline occurrences with fenced code blocks (specifying
language if desired) containing the expressions, and ensure the "no variables"
example is also inside its own fenced block so both render without MDX parsing
errors.
rectified few syntax errors
|
🚀 Deployed on https://deploy-preview-423--glific-docs.netlify.app |
changed expression added steps and more explaintion
Summary by CodeRabbit