port: IRQ masking primitives and interrupt-context tracking - #4
Closed
gmacd wants to merge 6 commits into
Closed
Conversation
Signed-off-by: Graham MacDonald <grahamamacdonald@gmail.com>
Signed-off-by: Graham MacDonald <grahamamacdonald@gmail.com>
Signed-off-by: Graham MacDonald <grahamamacdonald@gmail.com>
req_buffer_va/req_buffer_pa held VirtRange/PhysRange values; name them req_buf_virtrange/req_buf_physrange like the rest of the file. Also drop an unused pub on mbox_virtrange.
Add port::irq with an RAII IrqGuard (mask IRQs on new, restore the previous state on drop; nestable; no-op until an arch registers its mask/restore hooks) and an interrupt-depth counter (enter_interrupt/ exit_interrupt/in_interrupt) so subsystems can either mask around locks shared with interrupt context or assert they are never used from it. aarch64 registers a DAIF-based implementation at early boot and brackets the trap handler with the depth counter. Other arches are unaffected: the guard is a no-op and in_interrupt is always false until they opt in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
port::irq: an RAIIIrqGuardthat masks IRQs and restores the previous state on drop (nestable; a no-op until an arch registers mask/restore hooks), plus an interrupt-depth counter (enter_interrupt/exit_interrupt/in_interrupt). Subsystems can either mask around locks shared with interrupt context, or assert they are never used from it.aarch64 registers a DAIF-based implementation at early boot and brackets the trap handler with the depth counter. Behaviorally inert on its own: nothing takes a guard yet, and the other arches see no-ops.
Stacked on #3; review the last commit.