This repository was archived by the owner on Feb 18, 2020. It is now read-only.
Contracts/feature/new specs#127
Closed
hacker-DOM wants to merge 10 commits intocontracts/DX-2.0-No-Frontendfrom
Closed
Contracts/feature/new specs#127hacker-DOM wants to merge 10 commits intocontracts/DX-2.0-No-Frontendfrom
hacker-DOM wants to merge 10 commits intocontracts/DX-2.0-No-Frontendfrom
Conversation
Contributor
|
approved! |
…s/dutch-exchange into contracts/feature/newSpecs
Codecov Report
@@ Coverage Diff @@
## contracts/DX-2.0-No-Frontend #127 +/- ##
================================================================
+ Coverage 54.01% 54.25% +0.24%
================================================================
Files 10 10
Lines 785 763 -22
Branches 107 105 -2
================================================================
- Hits 424 414 -10
+ Misses 361 349 -12
Continue to review full report at Codecov.
|
W3stside
reviewed
Jan 13, 2018
| } else if (sellToken == ETH) { | ||
| tulipsToIssue = buyerBalance; | ||
| } else if (sellToken == ETH) { | ||
| tulipsToIssue = buyerBalance * price.num / price.den; |
Contributor
There was a problem hiding this comment.
should this not be tulipsToIssue = buyerBalance * price.den / price.num; as per line 580
Contributor
There was a problem hiding this comment.
nope scratch that, it's good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented everything I wanted to implement.
I'll have a look at Alex's solution for #96, other than that, we're done!