Fix incorrect viewed files counter if file has changed #36009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Nov 23, 2025
lunny
reviewed
Nov 24, 2025
lunny
approved these changes
Nov 24, 2025
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Nov 27, 2025
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Nov 27, 2025
File changes since last review didn't decrease the viewed files counter --- <img width="440" height="178" alt="image" src="https://github.com/user-attachments/assets/da34fcf4-452f-4f71-8da2-97edbfc31fdd" /> Also reported here -> go-gitea#35803 (comment) --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 28, 2025
* giteaofficial/main: Fix error handling in mailer and wiki services (go-gitea#36041) Update JS deps, fix deprecations (go-gitea#36040) Fix incorrect viewed files counter if file has changed (go-gitea#36009) [skip ci] Updated translations via Crowdin Fix actions lint (go-gitea#36029) Fix oauth2 session gob register (go-gitea#36017)
silverwind
pushed a commit
that referenced
this pull request
Nov 28, 2025
Backport #36009 by @bytedream File changes since last review didn't decrease the viewed files counter --- <img width="440" height="178" alt="image" src="https://github.com/user-attachments/assets/da34fcf4-452f-4f71-8da2-97edbfc31fdd" /> Also reported here -> #35803 (comment) Co-authored-by: bytedream <me@bytedream.dev> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Dec 2, 2025
* origin/main: [skip ci] Updated translations via Crowdin Fix bug when updating user email (go-gitea#36058) Add "Go to file", "Delete Directory" to repo file list page (go-gitea#35911) Replace `lint-go-gopls` with additional `govet` linters (go-gitea#36028) Fix Actions `pull_request.paths` being triggered incorrectly by rebase (go-gitea#36045) Fix error handling in mailer and wiki services (go-gitea#36041) Update JS deps, fix deprecations (go-gitea#36040) Fix incorrect viewed files counter if file has changed (go-gitea#36009)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File changes since last review didn't decrease the viewed files counter
Also reported here -> #35803 (comment)