Skip to content

Fix container registry error handling (#36021) #36037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2025
Merged

Fix container registry error handling (#36021) #36037

merged 1 commit into from
Nov 26, 2025

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Nov 26, 2025 •
edited by wxiaoguang
Loading

Backport #36021 by wxiaoguang

  1. the if check in handleCreateManifestResult didn't handler err correctly
  2. add more error details for debugging

@wxiaoguang @GiteaBot
Fix container registry error handling (go-gitea#36021)
7dcaf6a 
1. the `if` check in `handleCreateManifestResult` didn't handler err correctly
2. add more error details for debugging
@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 26, 2025
@GiteaBot GiteaBot added this to the 1.25.3 milestone Nov 26, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2025
@GiteaBot GiteaBot requested review from Zettat123 and lunny November 26, 2025 15:25
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 26, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2025
@lunny lunny merged commit d4d338f into go-gitea:release/v1.25 Nov 26, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@Zettat123 Zettat123 Awaiting requested review from Zettat123

Assignees

@wxiaoguang wxiaoguang

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code

Projects

None yet

Milestone

1.25.3

Development

Successfully merging this pull request may close these issues.

4 participants

@GiteaBot @lunny @lafriks @wxiaoguang