Skip to content

Fix container registry error handling #36021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2025
Merged

Fix container registry error handling #36021

merged 1 commit into from
Nov 25, 2025
+28 −29

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 25, 2025

  1. the if check in handleCreateManifestResult didn't handler err correctly
  2. add more error details for debugging

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 25, 2025
@wxiaoguang wxiaoguang mentioned this pull request Nov 25, 2025
Open
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 25, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 25, 2025
@wxiaoguang wxiaoguang merged commit abe2755 into go-gitea:main Nov 25, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 25, 2025
@wxiaoguang wxiaoguang deleted the fix-container-err branch November 25, 2025 04:13
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 25, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6615f41 
* giteaofficial/main:
  Fix container registry error handling (go-gitea#36021)
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 26, 2025
@wxiaoguang @GiteaBot
Fix container registry error handling (go-gitea#36021)
7dcaf6a 
1. the `if` check in `handleCreateManifestResult` didn't handler err correctly
2. add more error details for debugging
@GiteaBot GiteaBot mentioned this pull request Nov 26, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 26, 2025
lunny pushed a commit that referenced this pull request Nov 26, 2025
@GiteaBot @wxiaoguang
Fix container registry error handling (#36021) (#36037)
d4d338f 
Backport #36021 by wxiaoguang

1. the `if` check in `handleCreateManifestResult` didn't handler err
correctly
2. add more error details for debugging

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @lunny @Zettat123 @GiteaBot