feat(expander): add ExpandSchemaWithOptions for confined schema expansion - #291
Merged
Merged
Conversation
…sion ExpandSchema expands a schema against an in-memory root but takes no ExpandOptions, so it always uses the package default (unsandboxed) document loader. Downstream consumers that expand a schema whose $ref may come from an untrusted source — go-openapi/analysis (schema analysis, flatten) and go-openapi/validate — had no way to inject a confined loader on this path, and could not reassemble the equivalent themselves because the root-to-base priming (baseForRoot / normalizeBase) is unexported. Add ExpandSchemaWithOptions(schema, root, cache, opts): the option-aware form of ExpandSchema. It preserves the in-memory-root behavior (base derived from root, schemas always expanded) while honoring the caller's options — in particular PathLoaderWithOptions / PathLoader for a confined loader, plus ContinueOnError, AbsoluteCircularRef and MaxExpansionNodes. ExpandSchema is reimplemented as ExpandSchemaWithOptions(schema, root, cache, nil), so its behavior is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 68.45% 68.49% +0.03%
==========================================
Files 30 30
Lines 2435 2438 +3
==========================================
+ Hits 1667 1670 +3
Misses 599 599
Partials 169 169 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpandSchema expands a schema against an in-memory root but takes no ExpandOptions, so it always uses the package default (unsandboxed) document loader. Downstream consumers that expand a schema whose $ref may come from an untrusted source — go-openapi/analysis (schema analysis, flatten) and go-openapi/validate — had no way to inject a confined loader on this path, and could not reassemble the equivalent themselves because the root-to-base priming (baseForRoot / normalizeBase) is unexported.
Add ExpandSchemaWithOptions(schema, root, cache, opts): the option-aware form of ExpandSchema. It preserves the in-memory-root behavior (base derived from root, schemas always expanded) while honoring the caller's options — in particular PathLoaderWithOptions / PathLoader for a confined loader, plus ContinueOnError, AbsoluteCircularRef and MaxExpansionNodes. ExpandSchema is reimplemented as ExpandSchemaWithOptions(schema, root, cache, nil), so its behavior is unchanged.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist