Wasm: Fix mono patch application on Emscripten 1.38.47 - #44
Conversation
|
For the record, this patch application failure should also have affected previous container builds used in Godot 3.2 and 3.2.1. I did not notice it until now because of godotengine/godot-mono-builds/issues/6. I don't know what impact it has on our 3.2 and 3.2.1 WebAssembly templates for C#. |
I had a quick check at the supported Emscripten version in different Mono branches (I think we can assume that the hardcoded Emscripten version in Mono's
Latest emscripten today is 1.39.11. So yeah, we should make sure that our Wasm port does not expect cutting edge Emscripten versions, unless we're willing to go with Mono Nightly for our stable releases... We could consider an upgrade to Mono 6.10.x once it hits stable though, which gives us Emscripten 1.39.3 support without hacks. |
|
I confirm that the patches apply fine now when building a container against |
As a reminder, we pinned the Emscripten version to
1.38.47-upstreamas we had a regression with wasm generation in 1.38.48 and 1.39.x back in 17666f0.This patch comes from Mono's
2019-10branch (6.8.x): mono/mono#17094(Slightly amended to include a version bump in
wasm.mkthat should have been done by other intermediate patches.)We might need a recent Emscripten 1.39.x in the
3.2branch eventually (CC @Faless), so we might have to consider upgrading to a newer Mono branch with support for a more recent Emscripten.