Skip to content

Conversation

@dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Dec 11, 2025

I tested publishing the 4.6-beta1 release by putting the official build in the right spot and then running the build-android/upload-horizon.sh directly - and it worked!

However, since I haven't tested it by running publish-release.sh (which would then run build-android/upload-horizon.sh), I'm not 100% sure that will work, but the code looks correct-ish to me :-)

@dsnopek dsnopek force-pushed the publish-to-horizon-store branch from 077912a to c40bb73 Compare December 11, 2025 18:17
@dsnopek
Copy link
Contributor Author

dsnopek commented Dec 11, 2025

I added some code to the script to also upload the debug symbols, but I haven't tested it, and this isn't an argument I've ever used before so I'm not entirely sure how it works.

So, I should probably run the build-android/upload-horizon.sh script manually again after the beta2 release so I can make sure that it actually does the right thing

@dsnopek dsnopek force-pushed the publish-to-horizon-store branch from c40bb73 to 326b4cb Compare December 11, 2025 18:23
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

@dsnopek dsnopek force-pushed the publish-to-horizon-store branch from 326b4cb to c00f09e Compare December 11, 2025 19:19
@syntaxerror247
Copy link
Member

I added some code to the script to also upload the debug symbols, but I haven't tested it, and this isn't an argument I've ever used before so I'm not entirely sure how it works.

So, I should probably run the build-android/upload-horizon.sh script manually again after the beta2 release so I can make sure that it actually does the right thing

Can't you create a new private channel and upload to that, to test debug symbol upload?

Copy link
Member

@syntaxerror247 syntaxerror247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dsnopek
Copy link
Contributor Author

dsnopek commented Dec 11, 2025

Can't you create a new private channel and upload to that, to test debug symbol upload?

I did manage to come up with a way to sort of test it. The ovr-platform-util upload-debug-symbols command has equivalent arguments, so I tried those, and then updated the PR to match what worked there

@akien-mga akien-mga merged commit 7dca209 into godotengine:main Dec 12, 2025
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants