Update Spatial Material 3D page for Godot 4 #4587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
force-pushed
the
StandardMaterial
branch
from
98bd02a to
6b6e92d
Compare
clayjohn
reviewed
Jan 27, 2021
skyace65
force-pushed
the
StandardMaterial
branch
from
6b6e92d to
930c059
Compare
Contributor
Author
|
Fixed |
skyace65
force-pushed
the
StandardMaterial
branch
from
930c059 to
fb59713
Compare
Member
|
This has conflicts that need to be resolved :) |
Member
|
@skyace65 Just a friendly reminder bump. Thanks for all the work you do :) |
mhilbrunner
added
the
needs work
skyace65
force-pushed
the
StandardMaterial
branch
from
fb59713 to
657306a
Compare
Contributor
Author
|
I've fixed the merge conflict. This is going to need some more updates once I figure out how ORM Materials work. |
akien-mga
removed
the
needs work
clayjohn
reviewed
May 1, 2022
skyace65
force-pushed
the
StandardMaterial
branch
2 times, most recently
from
19deb03 to
5e3c618
Compare
Contributor
Author
|
Added a description for Filter and Repeat. I've also updated the beginning of the page for ORMMaterial3D. |
clayjohn
requested changes
May 2, 2022
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
Looks pretty good! Just a few little changes
Contributor
Author
|
Fixed. |
mhilbrunner
reviewed
May 3, 2022
Member
mhilbrunner
left a comment
mhilbrunner
left a comment
There was a problem hiding this comment.
Some small things, otherwise looks great!
Contributor
Author
|
Fixed. |
mhilbrunner
approved these changes
May 3, 2022
clayjohn
approved these changes
May 3, 2022
skyace65
force-pushed
the
StandardMaterial
branch
from
30a4d62 to
f37cffc
Compare
Contributor
Author
|
I've added the changes from #5826 for the new material overlay property. |
clayjohn
approved these changes
May 21, 2022
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SpatialmMaterial3D page for Godot 4.0. Most of this was reorganizing the page. The material is largely the same as in Godot 3.2 but everything is organized differently, and the flag section was removed.
-For the page layout a dashed line "----" is for a category and "~~~~~" is for a setting in that category.
-The image at the top of the page showing flags was replaced with one showing a list of all the settings (did png compression)
-Removed the ensure correct normals and line width sections as those settings have been removed.
-Changed wording for a few sections to reflect the new layout
-Added a back light description
-Added a description for next pass
-Replaced refrences of GLES3 with Vulkan
More work has to be done in the future, but I'd say this is a good start.