Skip to content

Conversation

@cake-pie
Copy link
Contributor

Depth renamed to Height; heading updated in #4587 but missed a mention in paragraph text.

@AThousandShips AThousandShips requested a review from a team July 23, 2024 18:22
@AThousandShips AThousandShips added topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:3d labels Jul 23, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice catch!

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clayjohn at the beginning of that section, should "depth map" be changed to "height map"?

@cake-pie
Copy link
Contributor Author

"depth map" be changed to "height map"?

You're right; I'll adjust that too.

Would it be helpful to also add a note + pointer to HeightMapShape3D? For any readers landing here while searching for use cases such as procedurally generated terrain heightmaps.

- This is not real added geometry, but an illusion of depth.
+ This only creates an illusion of depth, and does not add real geometry — for height map
+ shape used for physics collision (such as terrain) see :ref:`class_HeightMapShape3D`.

@clayjohn
Copy link
Member

Would it be helpful to also add a note + pointer to HeightMapShape3D? For any readers landing here while searching for use cases such as procedurally generated terrain heightmaps.

- This is not real added geometry, but an illusion of depth.
+ This only creates an illusion of depth, and does not add real geometry — for height map
+ shape used for physics collision (such as terrain) see :ref:`class_HeightMapShape3D`.

I think so!

@cake-pie
Copy link
Contributor Author

Done!

@cake-pie cake-pie requested review from clayjohn and skyace65 July 26, 2024 03:35
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change and this should be good.

Co-authored-by: Matthew <matthewehr@hotmail.com>
@skyace65 skyace65 merged commit f9f9b69 into godotengine:master Aug 1, 2024
@skyace65
Copy link
Contributor

skyace65 commented Aug 1, 2024

Thanks! And congrats on your first merged PR! In the future please keep PRs to 1 commit, I did a squash and merge this time but keep it in mind for the future. If you don't know how to do that we have a guide here

@cake-pie cake-pie deleted the StandardMaterialHeight branch August 2, 2024 02:42
@cake-pie
Copy link
Contributor Author

cake-pie commented Aug 2, 2024

Noted, thanks!

Lukas-Fletcher pushed a commit to Lukas-Fletcher/godot-docs that referenced this pull request Aug 24, 2024
* Depth renamed to Height in Standard Material 3D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:rendering topic:3d

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants