-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update standard_material_3d.rst to Godot 4 #9641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
clayjohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice catch!
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clayjohn at the beginning of that section, should "depth map" be changed to "height map"?
You're right; I'll adjust that too. Would it be helpful to also add a note + pointer to - This is not real added geometry, but an illusion of depth.
+ This only creates an illusion of depth, and does not add real geometry — for height map
+ shape used for physics collision (such as terrain) see :ref:`class_HeightMapShape3D`. |
I think so! |
|
Done! |
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor change and this should be good.
Co-authored-by: Matthew <matthewehr@hotmail.com>
|
Thanks! And congrats on your first merged PR! In the future please keep PRs to 1 commit, I did a squash and merge this time but keep it in mind for the future. If you don't know how to do that we have a guide here |
|
Noted, thanks! |
* Depth renamed to Height in Standard Material 3D
Depth renamed to Height; heading updated in #4587 but missed a mention in paragraph text.