Skip to content

Conversation

@rm-code
Copy link
Contributor

@rm-code rm-code commented Mar 1, 2023

Removed the instancing.zip as discussed in #6793 and replaced it with text and image references to the godot-projects instancing demo: https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing

Added a small section about instancing via code.

Closes #6793

Supersedes #6187 and #5374

@rm-code
Copy link
Contributor Author

rm-code commented Mar 1, 2023

@Calinou This is my draft for the changes discussed in #6793. Let me know if I should change anything. The instancing demo hasn't been updated yet so I think it would make sense to wait for that.

EDIT: Just noticed some of the highlights in my screenshots are missing ... will update again in a bit.

@mhilbrunner mhilbrunner added enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation cherrypick:4.0 labels Mar 2, 2023
@rm-code rm-code force-pushed the feature/6793 branch 2 times, most recently from 0b18f46 to 273d3d1 Compare March 4, 2023 19:15
@rm-code rm-code marked this pull request as ready for review March 4, 2023 19:17
@rm-code
Copy link
Contributor Author

rm-code commented Mar 4, 2023

Added a note about how to download the demo directly from github:
Bildschirmfoto 2023-03-04 um 20 13 01

Removed the instancing.zip as discussed in godotengine#6793 and replaced it with
text and image references to the godot-projects instancing demo:
https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing

Added a small section about instancing via code.

Closes godotengine#6793

Supersedes godotengine#6187 and godotengine#5374
@rm-code
Copy link
Contributor Author

rm-code commented Mar 6, 2023

As suggested by @YuriSizov in #5121 I removed the :article_outdated: True Tag with the latest update to this PR.

@skyace65
Copy link
Contributor

Superseded by #7222

@YuriSizov
Copy link
Contributor

YuriSizov commented Apr 28, 2023

Actually, this one is probably fine, as it updates the article itself.

The archive has been removed now, and the project template is accessible from a new repo (see also godotengine/godot-docs-project-starters#3). So the article can be adjusted to reflect that. Also images need to be converted to WebP.

@YuriSizov YuriSizov reopened this Apr 28, 2023
@skyace65 skyace65 added the needs work Needs additional work by the original author, someone else or in another repo label May 21, 2023
@skyace65
Copy link
Contributor

skyace65 commented Sep 4, 2024

Closing due to a lack of activity from the PR author

@skyace65 skyace65 closed this Sep 4, 2024
@Piralein Piralein removed the needs work Needs additional work by the original author, someone else or in another repo label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

archived area:getting started Issues and PRs related to the Getting Started section of the documentation enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use instancing example from godot-projects for the "Step by step: Instancing" page

6 participants