5373 - Step by step instancing example in zip file updated to new annotation style #5374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think we should remove this ZIP file and point to the demo project in https://github.com/godotengine/godot-demo-projects instead. This would avoid storing ZIP files within the documentation, which should be avoided for various reasons. |
Author
|
@Calinou I agree in general.
I'd prefer 3rd option, because first option is kind of more complicated then |
Author
|
@Calinou ? |
Member
|
@ueco-jb Since demos haven't been updated for Godot 4.0 yet, I would prefer we wait for 4.0 to be more stable to start upgrading all demos to Godot 4.0. Then we can look at updating the current instancing tutorial to reflect the demo's contents. 4.0.dev is not production-ready and therefore not recommended for beginners, so it's not a critical issue if beginner tutorials aren't updated yet. It will be done in due time 🙂 |
skyace65
added
the
area:getting started
rm-code
added a commit
to rm-code/godot-docs
that referenced
this pull request
Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with text and image references to the godot-projects instancing demo: https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing Closes godotengine#6793 Supersedes godotengine#6187 and godotengine#5374
rm-code
added a commit
to rm-code/godot-docs
that referenced
this pull request
Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with text and image references to the godot-projects instancing demo: https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing Closes godotengine#6793 Supersedes godotengine#6187 and godotengine#5374
rm-code
added a commit
to rm-code/godot-docs
that referenced
this pull request
Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with text and image references to the godot-projects instancing demo: https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing Closes godotengine#6793 Supersedes godotengine#6187 and godotengine#5374
rm-code
added a commit
to rm-code/godot-docs
that referenced
this pull request
Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with text and image references to the godot-projects instancing demo: https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing Closes godotengine#6793 Supersedes godotengine#6187 and godotengine#5374
rm-code
added a commit
to rm-code/godot-docs
that referenced
this pull request
Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with text and image references to the godot-projects instancing demo: https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing Closes godotengine#6793 Supersedes godotengine#6187 and godotengine#5374
rm-code
added a commit
to rm-code/godot-docs
that referenced
this pull request
Mar 1, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with text and image references to the godot-projects instancing demo: https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing Added a small section about instancing via code. Closes godotengine#6793 Supersedes godotengine#6187 and godotengine#5374
rm-code
added a commit
to rm-code/godot-docs
that referenced
this pull request
Mar 4, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with text and image references to the godot-projects instancing demo: https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing Added a small section about instancing via code. Closes godotengine#6793 Supersedes godotengine#6187 and godotengine#5374
rm-code
added a commit
to rm-code/godot-docs
that referenced
this pull request
Mar 4, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with text and image references to the godot-projects instancing demo: https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing Added a small section about instancing via code. Closes godotengine#6793 Supersedes godotengine#6187 and godotengine#5374
rm-code
added a commit
to rm-code/godot-docs
that referenced
this pull request
Mar 6, 2023
Removed the instancing.zip as discussed in godotengine#6793 and replaced it with text and image references to the godot-projects instancing demo: https://github.com/godotengine/godot-demo-projects/tree/4.0/2d/instancing Added a small section about instancing via code. Closes godotengine#6793 Supersedes godotengine#6187 and godotengine#5374
Contributor
|
Superseded by #7222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5373
It changes line in:
getting_started/step_by_step/files/instanting.zip/Main.gd