-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pause timeline button for scenes within the editor #31070
Conversation
ac28270
to
b49f740
Compare
b49f740
to
0af4f6c
Compare
I think its explanation should be more descriptive than just "Pause Timeline". |
Does this work on particles? If so, this would close #16397. |
Pause Scene Timeline ? or Pause Editor Timeline ?
Yeah, it will |
I can see some people think it only affects animation-related stuff at first, while in reality it pauses everything. |
@YeldhamDev What do you suggest ? |
To be honest, I am not convinced about the usefulness of this. This take a significant space on the toolbar for something which has a pretty limited use case. Also, for animations, I think this is confusing, as you now have two different ways to visually stop the animations, while they do not work the same way. However, if we really want that, I think the use case is too limited to have in on the toolbar, and it should be moved to a menu entry (maybe in the view menu ?) with a keyboard shortcut. |
View is not a good place for this, its not related to changing of the view.. What about pushing it to the Editor->Timeline submenu ? |
Pushed to 4.0. |
Closed, since I've lost interest in the promotion of it and don't want to waste time to resurrection. |
@Chaosus is there a possibility to have this in 3.2.x ? It would help with a problem I reported here #39758 Currently is hard to use the IDE when it has animations (of any kind) playing automatically. My laptop is burning right now due to this, because it uses a lot of CPU/GPU resources (more than 25%) even if the IDE is idle and I have no other software running. Having this switch, would help a lot. Thanks. |
@itsjavi In any case, it's too late to have a salvaged version of this PR merged into 3.2.2. 3.2.2rc3 was released a few days ago, and it's expected to be the last release candidate build. A salvaged version of this PR could make it into 3.2.3 though. Note that 3.2.2 will feature batching when using the GLES2 renderer, which should speed up rendering considerably when using that renderer. |
I am also getting the same performance issue in that version (3.2.2 RC3) @Calinou but I am using GLES3 in my project anyway. |
I think its useful to give the user possbility to stop game animations within the editor by setting editor time_scale to zero. Its useful when there is a lot of tool script or dynamic shaders within the scene and you want to pause and look at them at one moment. So I've just added a small button to do it. Its visible in both 2D and 3D editors.
Close #16397.