Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum line number being the line after enum #35976

Closed
wants to merge 1,317 commits into from
Closed

Fix enum line number being the line after enum #35976

wants to merge 1,317 commits into from

Conversation

Razoric480
Copy link
Contributor

Fixes #35975

@akien-mga akien-mga added this to the 4.0 milestone Feb 7, 2020
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 7, 2020
This was referenced Feb 7, 2020
Closed
Closed
akien-mga and others added 21 commits July 2, 2020 20:24
@akien-mga
Merge pull request godotengine#40051 from Faless/iteration/os_delay_3.2
3ec3b5f 
[3.2] Move frame delaying functions from Main to OS.
@akien-mga
Merge pull request godotengine#40052 from Faless/js/more_improvements…
2759fe8 
…_3.2

[3.2]  HTML5 fixes, audio fallback, fixed FPS.
@akien-mga
Merge pull request godotengine#40054 from bruvzg/macos_confined_mouse…
a3e525b 
…_mode_3

[macOS, 3.2] Implement confined mouse mode.
@akien-mga
Merge pull request godotengine#39996 from naithar/feature/ios-gdnative
24f527b 
[3.2] Add support of iOS's dynamic libraries to GDNative
@akien-mga
Merge pull request godotengine#33998 from nekomatata/printerr-remote-…
0bc2705 
…debugger

[3.2] Format remote printerr properly in script debugger output
@akien-mga
Merge pull request godotengine#37475 from azagaya/3.2
2286336 
Fixed images in black margins
@madmiraal @akien-mga
Call CRASH_COND_MSG if key not found in HashMap get function.
50d69a5 
(cherry picked from commit 1b05f44)
@timothyqiu @akien-mga
Prevent dragging from SceneTree buttons
38509f1 
(cherry picked from commit 45d0799)
@ThakeeNathees @akien-mga
animation autocomplete bug fixed
3a08658 
(cherry picked from commit b07e788)
@Xrayez @akien-mga
Clarify Geometry.offset_polygon_2d regarding vertices translation
f50c88b 
The method is used to either inflate or deflate a polygon.
For translating/transforming a polygon, use `Transform2D.xform`.

(cherry picked from commit 19b72da)
@paulherman @akien-mga
Expose loading TGA images in Image.
850f07a 
(cherry picked from commit 7d4b3e6)
@starryalley @akien-mga
VideoPlayer: fix possible race condition
46590fa 
In set_stream() we write to 'playback' while accessing the same object
in _mix_audio() in audio thread. Protect the 'write' part in
set_stream() to avoid possible crash in _mix_audio() function.

(cherry picked from commit e435d57)
@stijn-h @akien-mga
Deleting multiple nodes displays correct message.
4c54f39 
(cherry picked from commit 8b046ed)
@lordkettune @akien-mga
Fix issues with custom tracks on reimport
c68ef4d 
(cherry picked from commit 4313a7b)
@bruvzg @akien-mga
[macOS export] Set correct external file attributes (Unix mode), and …
14b8124 
…creation time.

(cherry picked from commit accae11)
@stijn-h @akien-mga
Add Control to preferred types
cdb9b51 
(cherry picked from commit ec86d32)

Fix crash by calculating wrong size of array.

(cherry picked from commit 81b6000)
@Calinou @akien-mga
Write "Aces" tonemapping in uppercase as it's an acronym
89421c5 
(cherry picked from commit a31fc59)
@follower @akien-mga
Revert "Adds fuzzy search for help search dialog"
9388237 
This reverts commit 481dbce.

Current fuzzy search implementation results in too many
non-useful results.

Could be re-added after result sort/filter/score functionality
is added. See godotengine#30072 for example existing implementation.

Fixes: godotengine#39128

Reverts: godotengine#32043

Fixed format style conflicts:
	editor/editor_help_search.cpp

(cherry picked from commit 55d706c)
@YeldhamDev @akien-mga
Fix Tree's 'scroll_to_item()' not working correctly on some cases
32c154d 
(cherry picked from commit 144a4cc)
@danielzting @akien-mga
Make "Close and save changes?" actually save
35523a4 
This fixes issue godotengine#39844, where the confirmation dialog when a user
attempts to close an unsaved script did not actually save it even after
clicking "Save."

(cherry picked from commit d2a5b92)
@akien-mga
Environment: Fix glow hdr bleed scale being unused
d004188 
The glow hdr bleed threshold was passed in its stead.

Fixed in master too with godotengine#40016.
Rubonnek and others added 21 commits July 29, 2020 18:23
@Rubonnek @akien-mga
Check if global class file still exists before registering it
4f9ca00 
(cherry picked from commit e264ae2)
@Calinou @akien-mga
Fix incorrect key name in the Animation documentation code sample
b3effe5 
This closes godotengine/godot-docs#3841.

(cherry picked from commit 4257aa5)
@Calinou @akien-mga
Add an example to the CanvasItem.draw_string() documentation
bd76fcd 
This closes godotengine/godot-docs#3374.

(cherry picked from commit 0c7735b)
@Calinou @akien-mga
Document how to perform advanced string splitting using RegEx
4a0568b 
This closes godotengine/godot-docs#3607.

(cherry picked from commit 5f2b6bd)
@Faless @akien-mga
Fix crash in ENet changing refuse_new_connections
e36c100 
When the host is not started.

(cherry picked from commit e5f3159)
@NeoSpark314
Added option to enable high precision float in GLES2
efe6b50 
An additional project setting under rendering/gles2/compatibility with the name
enable_high_float.Android is introduced that enables #define USE_HIGHP_PRECISION
in GLES2 shader on Android when it is supported by the shader compiler.
This fixes godotengine#33633 and godotengine#32813 and also GodotVR/godot_oculus_mobile#60
and GodotVR/godot_oculus_mobile#68 on devices that
support the highp (high precision) modifier.
@akien-mga
Merge pull request godotengine#33646 from NeoSpark314/gles2_highp
19802f7 
Added option to enable high precision float in GLES2
@akien-mga
doc: Sync classref with current source
6d2f8dd
@Calinou @akien-mga
Link to Thread-safe APIs in the Thread class documentation
2494224 
This closes godotengine/godot-docs#2276.

(cherry picked from commit f50a4b8)
@Calinou @akien-mga
Improve the EditorInterface.get_editor_viewport() description
2987fb3 
This closes godotengine/godot-docs#1109.

(cherry picked from commit 60d40d8)
@madmiraal @akien-mga
Ensure CSG parent's _make_dirty() is called when entering a tree.
c8d8134 
(cherry picked from commit 9be7b30)
@Calinou @akien-mga
makerst: Add descriptions to method qualifiers
78a6a57 
This closes godotengine/godot-docs#1753.

(cherry picked from commit c162a39)
@clayjohn
Properly calculate polygon2D AABB with skeleton
32928c2
@akien-mga
Merge pull request godotengine#40869 from clayjohn/3.2-polygon-aabb
f4d6830 
Properly calculate polygon2D AABB with skeleton
@akien-mga
Merge pull request godotengine#40791 from nekomatata/android-keyboard…
c49be9b 
…-cleaning-3.2

[3.2] Move PopupWindow logic to GodotEditText on Android
@Calinou @akien-mga
Add an example for creating a button in the Button class documentation
7c728f0 
This closes godotengine/godot-docs#3798.

(cherry picked from commit 8836c72)
@TheDuriel @akien-mga
Clarify TreeItem return values
7e9b7b0 
(cherry picked from commit 0ff1ca4)
@codetorex @akien-mga
Added missing information about File.open_encrypted function to docs.
3869b82 
(cherry picked from commit 3f6a7c7)
@Calinou @akien-mga
Improve JSON-related documentation
fc74512 
This closes godotengine/godot-docs#3848.

(cherry picked from commit 930e10f)
@akien-mga
CI: Pin Emscripten version to 1.39.20 temporarily
1244986 
1.40.0 introduced a regression for us:
emscripten-core/emscripten#11771

This is not necessary in the master branch, presumably because
it doesn't build any WebGL code (yet).
@akien-mga
Merge pull request godotengine#40914 from akien-mga/3.2-ci-emscripten…
23b553b 
…-1.39.20

CI: Pin Emscripten version to 1.39.20 to fix regression
@vnen
Copy link
Member

vnen commented Aug 8, 2020

This could be made as a PR for the 3.2 branch, since it's a bugfix. In master the line reporting should be correct, but even if it isn't it will require a different fix anyway.

@Razoric480 Razoric480 force-pushed the enum-parse-line-fix branch 3 times, most recently from e2633e2 to 23b553b Compare August 8, 2020 15:47
@Razoric480
Copy link
Contributor Author

Razoric480 commented Aug 8, 2020 •
edited
Loading

The PR is still targeting master and I'm not sure github will allow me to change it, so I'm going to close this and re-open it fresh for the 3.2 branch.

@Razoric480 Razoric480 closed this Aug 8, 2020
@Razoric480 Razoric480 deleted the enum-parse-line-fix branch August 8, 2020 15:48
@akien-mga akien-mga added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojidar-bg bojidar-bg Awaiting requested review from bojidar-bg

@vnen vnen Awaiting requested review from vnen

Assignees
No one assigned
Labels
archived bug topic:gdscript
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

GDScript parser reports named enum as having the line number after the closing brace