Fix List swap behavior on front, back and adjacent elements
#42013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2020 23:58
- immediately return if A == B; - first and last elements (front, back) are updated upon relinking; - handles a special case of forward and backward adjacent elements.
Adds a number of test cases for `List::swap()`.
|
Thanks! |
akien-mga
added
the
cherrypick:3.x
akien-mga
added
archived
cherrypick:3.x
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #41981
Listswap behavior on front, back and adjacent elements.A == B;I've added a test suite for
Listto test out these changes (both normal and stress tests) in a separate commit, so you can verify the fix more easily and perhaps make it easier to cherry-pick this to 3.2, but I can revert that commit and move everything to #41982 instead.I've stumbled upon this bug while trying to port existing Godot
Listimplementation to scripting in goostengine/goost#12.