fix for mouse events propagation after capturing mouse #64492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mouse is outside the window when Input.set_mouse_mode(Input.MOUSE_MODE_CAPTURED) is called, then after calling Input.set_mouse_mode(Input.MOUSE_MODE_VISIBLE) gui is not propagating some of the mouse events: buttons are not highlighted when mouse is hovering over them and some signals like mouse_entered/mouse_exited are not called. This commit fixes this issue by removing redundant check in viewport - if viewport is receiving mouse movement events that means mouse must be inside the viewport so there is no need for such check. It also removes gui.mouse_in_viewport member variable since it's not reliable.
|
cc @groud |
This assumption is unfortunately not true. The current event propagation system sends mouse-events to viewports, even if the mouse is outside of the viewport, as described in #28833. |
|
Superseded by #68482. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mouse is outside the window when Input.set_mouse_mode(Input.MOUSE_MODE_CAPTURED) is called, then after calling Input.set_mouse_mode(Input.MOUSE_MODE_VISIBLE) gui is not propagating some of the mouse events: buttons are not highlighted when mouse is hovering over them and some signals like mouse_entered/mouse_exited are not called.
This commit fixes this issue by removing redundant check in viewport - if viewport is receiving mouse movement events that means mouse must be inside the viewport so there is no need for such check.
It also removes gui.mouse_in_viewport member variable since it's not reliable - it's not updated at the time of mouse capturing.
closes #64438
This work was kindly sponsored by The Mirror