-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document known bugs with the Multi-Threaded thread model project setting #75365
Document known bugs with the Multi-Threaded thread model project setting #75365
Conversation
3f8278a
to
67a0052
Compare
67a0052
to
721b029
Compare
I would like someone from @godotengine/core to sign off on the |
I'm wondering if it wouldn't be better that, in case separate thread is requested, the engine forces single-safe and prints a warning telling about the "downgrade." |
On the other hand, we may want to fix this option to be eventually usable in the long term 🙂 So that's why I wouldn't prevent using it entirely. |
What I mean is, multi-threaded is kept as a pickable option, but until it's fixed, the engine assumes the closest safe option and informs the user about the matter. |
@RandomShaper tbf I'm pretty divided on this one: on one hand it would be the most consistent and useful choice but I'm seriously worried that once the thing actually becomes useful that people with it on (but what previously was due to this actually single thread mode) would eventually get hard-to-debug issues with it. |
721b029
to
21c4a0f
Compare
- Add a warning on project startup when using the Multi-Threaded option. - Improve command line validation for the `--render-thread` CLI argument.
21c4a0f
to
0613978
Compare
Thanks! |
--render-thread
CLI argument.