-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change scene drag-and-drop modifier behavior in the 2D and 3D editors #87623
Change scene drag-and-drop modifier behavior in the 2D and 3D editors #87623
Conversation
Behavior is now consistent across 2D and 3D editors. - By default, drag-and-dropping adds the scene as a child of the selected node. Hold Alt when releasing the mouse to add the scene as a child of the root node, or Shift to add the scene as a sibling of the selected node. - To choose a different node type in the 2D editor when drag-and-dropping a texture resource, hold Alt + Shift (instead of just Alt). - If multiple nodes are selected, only the first one is taken into account. This was previously the behavior in 2D, but not in 3D (an error dialog appeared instead). This makes the UI more forgiving.
#87126 is related. |
Tested every scenario in the description. Seems to work. |
For 2D, the current behavior was implemented in #51011 |
Using Alt+Shift for changing type makes it impossible to change type and add as sibling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine overall.
The Shift+Alt conflict I mentioned is a corner-case, I'm not sure what modifier we could use to deconflict it. Maybe it's fine this way.
Thanks! |
Behavior is now consistent across 2D and 3D editors.
Ctrl is no longer used in shortcuts because it interferes with the grid snapping toggle. Using Alt in shortcuts here is fine, because it's checked when the mouse is released, not when it's pressed. Therefore, it'll work correctly on Linux with window manager defaults.
Preview
I hold Alt when performing the last drag-and-drop operation, which is why the last node is added to the root node instead.
simplescreenrecorder-2024-01-26_18.00.20.mp4