-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the smoothstep degenerate case of empty range #93149
Handle the smoothstep degenerate case of empty range #93149
Conversation
d20e5d0
to
9726b9c
Compare
58ba182
to
5ad565f
Compare
@kleonc I copied your fix for the double implementation over to the float and squashed the commits in preparation for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
But since I've proposed changing it to the current version, another opinion / approval would be good.
+Remainder for before merging:
Note that it depends on godotengine/godot-docs#9489 to go in first so the graph URL links work.
6e713ca
to
e9213c5
Compare
I updated the PR to match the updated graph in the godotengine/godot-docs#9489 pull request. I would request people review that PR (which just adds the image) in order to get this dependent PR merged. |
e9213c5
to
26b22b2
Compare
The godot-docs image was converted from png to webp to align with the guidelines. As such this PR has been updated to refer to the webp image. |
Looks good. Just needs a rebase before merging. Feel free to do that after 4.3 releases so you don't end up having to rebase again (since this needs to wait for 4.4 before merging) |
It also updates the documentation to describe positive and negative ranges. Co-Authored-By: Hugo Locurcio <hugo.locurcio@hugo.pro> Co-Authored-By: kleonc <9283098+kleonc@users.noreply.github.com>
759541f
to
23fc704
Compare
Rebased |
Thanks! |
This PR fixes issue #68128 by handling the empty-range case as a binary-divisor between 0.0 and 1.0.
It also updates the documentation to describe positive and negative ranges.
Note that it depends on godotengine/godot-docs#9489 to go in first so the graph URL links work.
Bugsquad edit: