Fix LightmapGI not taking environment sky rotation into account when baking #95000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
lightmapgi-environment-fix-custom-rotation-bake
branch
3 times, most recently
from
ed8f9c9 to
dd4ff7e
Compare
Calinou
added
the
cherrypick:4.3
clayjohn
reviewed
Aug 1, 2024
…baking The sky rotation now affects the baked environment lighting as it should, making it match how real-time ambient light rendering works. Co-authored-by: Per Melin <git@melin.net>
Calinou
force-pushed
the
lightmapgi-environment-fix-custom-rotation-bake
branch
from
dd4ff7e to
661cf1f
Compare
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sky rotation now affects the baked environment lighting as it should, making it match how real-time ambient light rendering works.
Tested on all rendering methods. Thanks @permelin for contributing this fix 🙂
Testing project: test_lightmap_environment_custom_orientation.zip
Preview
Left = real-time lighting, right = baked lighting.
Default sky rotation
No change (as expected).
Custom sky rotation
Previously, the baked environment light did not rotate at all.