Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Initial Clip property if not relevant in AudioStreamInteractive editor #95136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 4, 2024

If no clips have been created yet, there's no clip to choose from for the Initial Clip property.

PS: Is there a way to force the parameter list to be updated? This would allow Switch to Clip to be hidden if there are no clips as well:

r_parameters->push_back(Parameter(PropertyInfo(Variant::STRING, "switch_to_clip", PROPERTY_HINT_ENUM, clip_names, PROPERTY_USAGE_EDITOR), ""));

The following code works, but it doesn't update when you add/remove a clip until you reselect the node:

r_parameters->push_back(Parameter(PropertyInfo(Variant::STRING, "switch_to_clip", PROPERTY_HINT_ENUM, clip_names, get_clip_count() == 0 ? PROPERTY_USAGE_NO_EDITOR : PROPERTY_USAGE_EDITOR), ""));

Fixing this would allow fully closing #94140 when coupled with #95134.

Preview

audio_interactive_editor_initial_clip.mp4

@Calinou Calinou added bug topic:editor topic:audio cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 4, 2024
@Calinou Calinou added this to the 4.4 milestone Aug 4, 2024
…editor

If no clips have been created yet, there's no clip to choose from
for the Initial Clip property.
@Calinou Calinou force-pushed the audio-interactive-transition-editor-hide-initial-clip branch from 99d6ff6 to 378b684 Compare August 5, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:audio topic:editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants