Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Default Project Path" to Project Manager's Quick Settings #99608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Meorge
Copy link
Contributor

@Meorge Meorge commented Nov 24, 2024

Closes godotengine/godot-proposals#11224.

This PR adds "Default Project Path" to the Project Manager's Quick Settings menu. Since this setting will mostly (exclusively?) be used from the Project Manager, and before a project in a location is created, this seems like a more natural place for it. (Of course, it is still accessible from the Editor Settings within the Editor.)

Godot.Default.Project.Path.in.Project.Manager.mp4

…k Settings

Currently a limited reimplementation of EditorPropertyPath, but lacking drag support
@Meorge Meorge requested a review from a team as a code owner November 24, 2024 00:48
@tetrapod00 tetrapod00 added this to the 4.x milestone Nov 24, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

On the other hand, I'd prefer a solution like godotengine/godot-proposals#1312 which is more intuitive as users will discover it automatically. It would probably require less code to be implemented too.

PS: While testing this PR, I found a bug that also happens in 4.3.stable: #99689

@Meorge
Copy link
Contributor Author

Meorge commented Nov 25, 2024

Thanks for testing it! 😄

That is a good point you bring up about it just defaulting to the path that the last project was saved in. With this PR, even though the setting is accessible from the Project Manager, it's still fairly out of the way, and a newcomer may not think to check the "Settings" page to configure their project path before going in to create a new project. Most programs do keep track of the last save location, and default to that, so the behavior from that proposal would also align more with a standard.

One sort-of-downside I see to that proposed alternate solution is that it might make the "Default Project Path" property as a whole kind of useless as a configurable editor property, since it would effectively just apply to the single next project you create (i.e., if you create another project in a different directory, it'd overwrite the property value to that). So if we were to go that route, it wouldn't make sense to me for it to be exposed as a property in either the editor or the Project Manager settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Default Project Path" to Project Manager Settings
3 participants