Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
crypto/x509: SystemCertPool documentation is not clear that modifications to the cert pool supplied are isolated from other pools returned by the function #27385
What version of Go are you using (
@FiloSottile The "makes a copy" on the first line helped too for sure, but I found it ambiguous in the context of the next line saying it returns "the" pool, and not "a" pool. I wasn't sure if "copy" meant a copy of what's on disk, or that it literally made a copy on every call.
(I forgot to mention the "the" vs "a" on this issue before I opened the CL.)
The words 'the returned' were changed to 'a returned' in 8201b92 when referring to the value returned by SystemCertPool. Brad Fitz pointed out after that commit was merged that it makes the wording of this function doc inconsistent with rest of the stdlib since 'a returned' is not used anywhere, but 'the returned' is frequently used. Fixes #27385 Change-Id: I289b533a5a0b5c63eaf0abb6dec0085388ecf76b GitHub-Last-Rev: 6c83b80 GitHub-Pull-Request: #27438 Reviewed-on: https://go-review.googlesource.com/132776 Reviewed-by: Brad Fitzpatrick <email@example.com>