Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: return non-200 for timeout errors #38576

Open
toothrot opened this issue Apr 21, 2020 · 1 comment
Open

x/playground: return non-200 for timeout errors #38576

toothrot opened this issue Apr 21, 2020 · 1 comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

toothrot commented Apr 21, 2020 •
edited
Loading

Timeout errors currently must return a 200 status to be rendered correctly by the Playground javascript. The javascript needs to be updated to also parse 4xx errors correctly, then the playground should be updated to return responses with a correct code. Currently, unsuccessful requests of any kind are treated the same as a 5xx.

This may have implications for the Tour or other places where the playground is used.

Related to #38546
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 21, 2020
@toothrot toothrot added this to the Unreleased milestone Apr 21, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/229307 mentions this issue: playground: stop storing timeouts in cache

gopherbot pushed a commit to golang/playground that referenced this issue Apr 23, 2020
@toothrot
playground: stop storing timeouts in cache
11cd822 
This changes the Playground to stop storing build and run timeout
responses in the cache. These responses could get cached when the
Playground was unhealthy, leaving some trivial snippets to be cached
incorrectly, confusing users.

Adds testing for our caching logic.

Updates golang/go#38546
Updates golang/go#38576

Change-Id: Idd2106d673162d9eea8536fe2433f74c23ed6e8a
Reviewed-on: https://go-review.googlesource.com/c/playground/+/229307
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@toothrot @gopherbot