Fix least_squares result when xtol is reached - #3418
Merged
copybara-service[bot] merged 1 commit intoJul 22, 2026
Merged
Conversation
kevinzakka
approved these changes
Jul 22, 2026
kevinzakka
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xtolleast_squaresreturns that accepted candidateProblem
When an accepted step satisfies the relative step-size tolerance,
least_squaressetsDX_TOLand exits before assigningxnewandrnew. It therefore returns the previous, higher-objective iterate and records that stale iterate in the final trace.Testing
test_xtol_returns_accepted_candidate: passedpython/mujoco/minimize_test.pymodule: 16 tests passedtrailing-whitespace: passedend-of-file-fixer: passedgit diff --check: passed