Fix use the default hostname verifier - #1060
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
fix_hostname_verifier
branch
from
May 4, 2022 15:17
869bb2f to
1ad7436
Compare
prbprbprb
approved these changes
Oct 18, 2022
Contributor
|
Thanks! |
prbprbprb
added a commit
to prbprbprb/conscrypt
that referenced
this pull request
Jan 2, 2023
Signed-off-by: Zixuan Liu <nodeces@gmail.com> Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: Pete Bentley <44170157+prbprbprb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zixuan Liu nodeces@gmail.com
Fix #1015
When no set the HostnameVerifier in
TrustManagerImpl, we should use thedefaultHostnameVerifier, if which still is not set we will use thePlatform.getDefaultHostnameVerifier().