Moe Sync#3440
Merged
Merged
Conversation
This adds five headers, as defined in RFC 6455: Sec-WebSocket-Accept, Sec-WebSocket-Extensions, Sec-WebSocket-Key, Sec-WebSocket-Protocol, and Sec-WebSocket-Versions. This also changes the C++ per-header unit test so that it can recognize the alternate capitalization of WebSocket, instead of adding five special cases. The Go and Java versions use the "Websocket" capitalization instead. RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=242732915
ronshapiro
added
the
internal-sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Add websocket headers to HTTP header listings.
This adds five headers, as defined in RFC 6455: Sec-WebSocket-Accept,
Sec-WebSocket-Extensions, Sec-WebSocket-Key, Sec-WebSocket-Protocol, and
Sec-WebSocket-Versions.
This also changes the C++ per-header unit test so that it can recognize the
alternate capitalization of WebSocket, instead of adding five special cases. The
Go and Java versions use the "Websocket" capitalization instead.
78fe310