Moe Sync#3531
Merged
Merged
Conversation
… order but does *not* necessarily expose the keys in sorted order. RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=257601507
RELNOTES=none ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=257615215
Prevent J2ObjC from treating `getAddSuppressed` as a getter by renaming it `generateAddSuppressed`. This silences a -Wobjc-property-implementation warning; soon, such warnings will become errors. See the referenced bug for full context. RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=257616241
ronshapiro
added
the
internal-sync
Contributor
|
@ronshapiro The comment above looks like a very strange attempt at spam. Vote to remove it? :) (If you agree, I'll remove this comment too to prevent confusion.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Clarify that SortedSetMultimap exposes the values for a key in sorted order but does *not* necessarily expose the keys in sorted order.
09bf107
Remove unneeded @SuppressWarnings from @benchmark methods.
RELNOTES=none
3c3f7c9
Rename a method to avoid J2ObjC collisions
Prevent J2ObjC from treating
getAddSuppressedas a getter by renaming itgenerateAddSuppressed. This silences a -Wobjc-property-implementation warning; soon, such warnings will become errors. See the referenced bug for full context.cc5a55e