Make Lists.transform() delegate spliterator() to the backing list. - #8644
Open
Divyansh151005 wants to merge 1 commit into
Open
Make Lists.transform() delegate spliterator() to the backing list.#8644Divyansh151005 wants to merge 1 commit into
Lists.transform() delegate spliterator() to the backing list.#8644Divyansh151005 wants to merge 1 commit into
Conversation
Fixes google#8165 RELNOTES=`collect`: Fixed `Lists.transform()` to delegate `spliterator()` to the backing list so characteristics such as `IMMUTABLE` are preserved and streaming over a concurrently modified list (for example `CopyOnWriteArrayList`) no longer throws `ConcurrentModificationException`. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Lists.transform()list views did not overridespliterator(). They inheritedAbstractList/AbstractSequentialListspliterators that iterate via indexed access or list iterators on the transformed view. For backing lists with special spliterator behavior (notablyCopyOnWriteArrayList, whose spliterator snapshots the array), streaming over the transformed view could throwConcurrentModificationExceptionwhile the backing list was being modified concurrently.Example from the issue:
Fixes #8165
Solution
Override
spliterator()on bothTransformingRandomAccessListandTransformingSequentialListto delegate throughCollectSpliterators.map(fromList.spliterator(), …), matchingCollections2.transformandIterables.transform.Testing
New tests verify characteristic delegation for random-access and sequential transforms, and that streaming over
Lists.transform(copyOnWriteArrayList, …)does not throw while the backing list is mutated concurrently.