Fix text reconversions on Excel for Windows#1385
Merged
Merged
Conversation
This follows up my previous commit [1], which aimed to support surrounding text retrieval on Chromium-based apps. However, it turned out that it broke text reconversion on Excel. This commit aims to fix the text reconversion on Excel while keeping the support for surrounding text retrieval on Chromium-based apps. A short takeaway is that Excel has relied on 'ITfFnReconversion', where the application (Excel) is responsible for providing ITfRange object from which IMEs can retrieve the surrounding text. Special rules implemented in 'TipSurroundingText::Get' are not necessary when a valid ITfRange object is already given. This is what I have overlooked even before the culprit commit. This commit utilizes the existing 'TipEditSession::GetTextSync' as it already takes an ITfRange object to return the selected text. For now reusing it would be the simplest solution. Closes google#1384. [1]: a2af432.
Collaborator
|
We have merged your PR. |
hiroyuki-komatsu
added a commit
that referenced
this pull request
Oct 22, 2025
2.32.5981 → 2.32.5994 Conversion * Do not remember punctuation-ending non-Japanese (ASCII) strings directly input by the composer. (5e09d3d) Feature * Stop providing "did you mean" description on language aware rewriter. (353859a) Bug fix * Windows: Fix text reconversions on Excel (#1385) * Windows: Avoid flickering of composing text on Windows (#1389) Code * Windows: Always let server/renderer run in Win32 Jobs (#1379) 2.31.5851 → 2.32.5981 Conversion * Updated the language model (11a5dc3) * Updated zip-code as of 2025-08-30 (53e6db7) * Removed the 62-day storage limit for input history. Retain the history up to the data size limit. (12f6d98) * Fix an overfiltering of candidates that have the same key and longer common prefix value. (1dfd91b) + e.g. 堺 (さかい) was overfilitered as 堺井(さかい) is also an candidate. * Updated some data entries (#1331, #1351, #1360, #1374) * Updated the candidate filtering rule (9d7332c) * Updated the logic of word suggestion for multiple segments (aka inner boundary) (22adec5) Bug fix * Fix an issue that the top candidate with multiple segments may get broken. (f3437a0) * Linux: Fix a crash issue on some Linux environment that does not support _SC_GETPW_R_SIZE_MAX (#1318) * macOS: Fix a crash issue of the installer on macOS 26 (Tahoe) (018d8d9) * Windows: Fix a UI issue that mouse clicking on the candidate window did not work. (#1372) + Regression on 2.31.5851 Packaging * Support specifying the version number as a Bazel command line option (4f48688) * e.g. Bazel build package --action_env=MOZC_VERSION="2.31.5810.0" * Android: made libmozc.so compatible with 16 KB page sizes (#1364) * macOS: supported .dmg file generation with codesign * macOS: updated the required version from macOS11 to macOS12 * Windows: Supported ARM64 build (#1130) * Windows: Removed unused PDB (#1261) * Windows: Support OS build number check (#1329) Build * Removed the build time dependency on Unicode's text files (#1353) * Updated Bazel: 8.1.1 → 8.4.1 * Updated Abseil: 20250127.1→ 20250814.0 * Updated Protobuf: v29.3 → v32.0 * Updated googletest: v1.15.2 → v1.17.0 * Updated Qt: 6.8.0 → 6.9.1 * GitHub Actions: updated macOS environment 14 → 15 * GitHub Actions: updated Windows environment 2022 → 2025 Code * Added lattice viewer (3c62c59) * Updated the coding style (i.e. "string &s" → "string& s"). * Performed a number of refactoring. PiperOrigin-RevId: 822376409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This follows up my previous commit (a2af432) , which aimed to support surrounding text retrieval on Chromium-based apps. However, it turned out that it broke text reconversion on Excel. This commit aims to fix the text reconversion on Excel while keeping the support for surrounding text retrieval on Chromium-based apps.
A short takeaway is that Excel has relied on
ITfFnReconversion, where the application (Excel) is responsible for providingITfRangeobject from which IMEs can retrieve the surrounding text. Special rules implemented inTipSurroundingText::Getare not necessary when a validITfRangeobject is already given. This is what I have overlooked even before the culprit commit.This commit utilizes the existing
TipEditSession::GetTextSyncas it already takes anITfRangeobject to return the selected text. For now reusing it would be the simplest solution.Closes #1384.
Issue IDs
Steps to test new behaviors (if any)