Revise unsafe Rust skill to V2 after V1 evaluation failures - #3522
Open
joshlf wants to merge 1 commit into
Open
Conversation
Translate the V1 evaluation failures into general proof rules rather than adding fixture-specific hazard trivia. Require CONTRACT-BROKEN to have a valid UB-free falsifying execution. An execution that contains UB may prove UNSOUND, but it cannot establish a defined observation before or after the UB; without a separate UB-free witness, the corresponding behavioral promise remains UNPROVED. Require an explicit supported toolchain and configuration predicate, preserve conflicting controlling policy sources, distinguish a conservative audit domain from the project's unresolved support promise, and reject an earliest version, CI sample, or convenient policy interpretation as proof of the whole domain. Forbid promotion of one constructor, conversion, deserializer, or other producer's precondition into a universal invariant of its output type. Require an authoritative universal premise, enforced construction-and-preservation closure, a verified theorem or explicit TCB premise, or a derivation specific to the values actually consumed. Strengthen literal-clause closure, full supported-domain composition, and boundary and adversarial falsification before PROVED. Update the report template and proof, configuration, API, and reporting references to carry the same rules. gherrit-pr-id: Gxw7ewqzcrigbrgikdrjkmx2nnotda4uz
This was referenced Aug 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G3y45zv35fuuyeejc26bftqdd33lqz2oh #3522 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate the V1 evaluation failures into general proof rules rather than
adding fixture-specific hazard trivia.
Require CONTRACT-BROKEN to have a valid UB-free falsifying execution. An
execution that contains UB may prove UNSOUND, but it cannot establish a defined
observation before or after the UB; without a separate UB-free witness, the
corresponding behavioral promise remains UNPROVED.
Require an explicit supported toolchain and configuration predicate, preserve
conflicting controlling policy sources, distinguish a conservative audit domain
from the project's unresolved support promise, and reject an earliest version,
CI sample, or convenient policy interpretation as proof of the whole domain.
Forbid promotion of one constructor, conversion, deserializer, or other
producer's precondition into a universal invariant of its output type. Require
an authoritative universal premise, enforced construction-and-preservation
closure, a verified theorem or explicit TCB premise, or a derivation specific
to the values actually consumed.
Strengthen literal-clause closure, full supported-domain composition, and
boundary and adversarial falsification before PROVED. Update the report
template and proof, configuration, API, and reporting references to carry the
same rules.
Latest Update: v2 — Compare vs v1
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gxw7ewqzcrigbrgikdrjkmx2nnotda4uz && git checkout -b pr-Gxw7ewqzcrigbrgikdrjkmx2nnotda4uz FETCH_HEADCheckout
git fetch origin refs/heads/Gxw7ewqzcrigbrgikdrjkmx2nnotda4uz && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gxw7ewqzcrigbrgikdrjkmx2nnotda4uz && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.