ci(oauth2): only test RAB when enabled#16246
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request conditionally compiles the RABExternalAccountCredentials integration test based on the GOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB preprocessor macro, skipping the test if the macro is not defined. The reviewer suggested improving the test skip logic by providing a descriptive message to GTEST_SKIP() to explain why the test was skipped.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16246 +/- ##
==========================================
- Coverage 92.26% 92.26% -0.01%
==========================================
Files 2214 2214
Lines 206307 206307
==========================================
- Hits 190358 190350 -8
- Misses 15949 15957 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
There are clang-tidy issues. |
dbolduc
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.