Skip to content

ci(oauth2): only test RAB when enabled #16246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotthart merged 2 commits into from
Jul 13, 2026
+7 −2
Merged

ci(oauth2): only test RAB when enabled #16246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8998d11
ci(oauth2): only test RAB when enabled
scotthart Jul 10, 2026
2c5673e
fix clang tidy issues
scotthart Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions google/cloud/internal/external_account_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
namespace {

using ::google::cloud::internal::GetEnv;
#ifdef GOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB
using ::google::cloud::testing_util::IsOkAndHolds;

auto constexpr kEndpointThatUsesRAB = "storage.googleapis.com";
#endif

MATCHER_P(NonEmptyHttpHeaderNameIs, header_name, "has non-empty header named") {
return header_name == arg.name() && !arg.EmptyValues();
Expand Down Expand Up @@ -150,6 +150,8 @@ TEST(ExternalAccountIntegrationTest, ExternalAccountCredentials) {
}

TEST(ExternalAccountIntegrationTest, RABExternalAccountCredentials) {
#ifdef GOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB
auto constexpr kEndpointThatUsesRAB = "storage.googleapis.com";
auto contents = GetExternalAccountCredentialsContents();
if (contents.empty()) GTEST_SKIP();

Expand All @@ -173,6 +175,9 @@ TEST(ExternalAccountIntegrationTest, RABExternalAccountCredentials) {
EXPECT_THAT(headers,
IsOkAndHolds(::testing::Contains(NonEmptyHttpHeaderNameIs(
std::string{"x-allowed-locations"}))));
#else
GTEST_SKIP() << "RAB testing is not enabled";
#endif
} // namespace
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
} // namespace oauth2_internal
Expand Down
Loading