Add setDefaultCloudStorageConfiguration#2159
Add setDefaultCloudStorageConfiguration#2159michaelbausor merged 4 commits intogoogleapis:masterfrom
Conversation
This allows the main program to set default options that will be used
by all subsequent filesystem objects. This is useful for a main program
that has libraries that create their own Path objects via the
recommended way (Paths.get(URI.create("gs://..."))).
googlebot
added
the
cla: yes
| CloudStorageFileSystemProvider.setStorageOptions(LocalStorageHelper.getOptions()); | ||
| } | ||
|
|
||
| @Test |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@jean-philippe-martin Would you be able to build a snapshot of GATK built against this branch, modify it to use the new global config mechanism, and confirm in a debugger (or via printed debug output) that the setting for both retries and reopens is propagating all the way down to |
|
Thank you for implementing this by the way @jean-philippe-martin -- really hoping that we can get both this PR and the infinite recursion fix in #2124 merged in time for the next |
| * filesystem object with the right configuration and pass it along. | ||
| * | ||
| * @param newDefault new default CloudStorageConfiguration | ||
| */ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@shinfan could you take a look? |
|
Thank you very much! |
|
The travis build failed with "The job exceeded the maximum time limit for jobs" in one of the builds -- possibly this is a transient failure, rather than anything to do with this change? Could we re-run the travis build @jean-philippe-martin? |
|
Or @garrettjonesgoogle? Help? |
|
Could we please get a re-run on the Travis CI build for this branch? The failure looks transient/unrelated to this PR, and the PR has otherwise been approved. We'd really love to see this one merged! |
|
@michaelbausor could you finish this up? |
|
Rerunning Travis now |
|
Thanks! |
…a 8 (#1800) (#2159) * chore: Java 8 unit test to build code in Java 17 and run tests on Java 8 (#1800) * Our Java projects are configured to produce Java 8-compatible bytecode via https://github.com/googleapis/java-shared-config/blob/main/pom.xml#L848. This unit test change ensures this config is applied correctly. * This change also switches the JDK distribution of GitHub Actions to temurin from zulu. * For the repositories that mark "dependencies (8)" and "dependencies (11)" as required, they should point to only "dependencies (17)" via `.github/sync-repo-settings.yaml` and repo's Settings tab. Source-Link: googleapis/synthtool@cbe0100 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:32851debfefed2b66038e0141f1b5c2103bb59ba80b7475adbc10ef7abab3de7 * dependencies (17) * unit 8 build --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tomo Suzuki <suztomo@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
7 participants
This allows the main program to set default options that will be used
by all subsequent filesystem objects. This is useful for a main program
that has libraries that create their own Path objects via the
recommended way (Paths.get(URI.create("gs://..."))), so the main
program can set eg. retry options for everyone to use.