feat!: Update common to minimum Node version of 22. - #8988
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
danieljbruce
added a commit
that referenced
this pull request
Jul 29, 2026
# Description Right now we are upgrading Node on client libraries to only support versions 22+ so open PR tests are naturally failing when trying to run the tests on Node version 18. While we could remove testing for Node 18 only after we officially drop support for Node 18 to catch specific Node 18 issues in the short term, we create a situation in our CI where our unit tests will always fail on Node 18 and unit tests for other Node versions don't run like in #8988 after the upgrade. Therefore, we want to remove Node 18 testing right now in order to keep the tests running for other versions and avoid having a Node 18 unit test that we expect to fail. The github actions also needed to be updated for the zizmor check. ## Impact Ensure testing infrastructure is still useful as we do the Node upgrade.
westarle
approved these changes
Jul 29, 2026
danieljbruce
enabled auto-merge (squash)
July 29, 2026 19:39
danieljbruce
pushed a commit
that referenced
this pull request
Jul 29, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>common: 7.0.0</summary> ## [7.0.0](common-v6.1.0...common-v7.0.0) (2026-07-29) ### ⚠ BREAKING CHANGES * Update common to minimum Node version of 22. ([#8988](#8988)) ### Features * Update common to minimum Node version of 22. ([#8988](#8988)) ([d38c05a](d38c05a)), refs [#8985](#8985) </details> <details><summary>agentidentity: 0.1.0</summary> ## 0.1.0 (2026-07-29) ### Features * **google/cloud/agentidentity/v1beta:** Onboard a new library ([#9013](#9013)) ([acd5989](acd5989)) * **google/cloud/agentidentity/v1:** Onboard a new library ([#9014](#9014)) ([b4cef83](b4cef83)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade the Node version from 18 to 22.
Towards #8985