feat(google/cloud/agentidentity/v1beta): onboard a new library - #9013
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new @google-cloud/agentidentity package, adding its protobuf definitions, auto-generated samples, and package configuration. However, the critical client implementation file auth_provider_service_client.ts is missing, which will cause compilation to fail. Additionally, feedback suggests adding the types field to package.json for TypeScript consumers and removing the unnecessary dom library from tsconfig.json to prevent global namespace pollution.
| // ** https://github.com/googleapis/gapic-generator-typescript ** | ||
| // ** All changes to this file may be overwritten. ** | ||
|
|
||
| export { AuthProviderServiceClient } from './auth_provider_service_client'; |
There was a problem hiding this comment.
The client implementation file auth_provider_service_client.ts is missing from this pull request. Since index.ts attempts to export AuthProviderServiceClient from ./auth_provider_service_client, the TypeScript compilation will fail. Please ensure that all generated source files (including the client implementation and unit tests) are committed and included in this PR.
| "license": "Apache-2.0", | ||
| "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/packages/google-cloud-agentidentity", | ||
| "author": "Google LLC", | ||
| "main": "build/src/index.js", |
There was a problem hiding this comment.
The package.json file is missing the types field. For TypeScript consumers to properly resolve the type definitions of this package, please specify the types field pointing to the compiled declaration file.
"main": "build/src/index.js",
"types": "build/src/index.d.ts",
🤖 I have created a release *beep* *boop* --- <details><summary>common: 7.0.0</summary> ## [7.0.0](common-v6.1.0...common-v7.0.0) (2026-07-29) ### ⚠ BREAKING CHANGES * Update common to minimum Node version of 22. ([#8988](#8988)) ### Features * Update common to minimum Node version of 22. ([#8988](#8988)) ([d38c05a](d38c05a)), refs [#8985](#8985) </details> <details><summary>agentidentity: 0.1.0</summary> ## 0.1.0 (2026-07-29) ### Features * **google/cloud/agentidentity/v1beta:** Onboard a new library ([#9013](#9013)) ([acd5989](acd5989)) * **google/cloud/agentidentity/v1:** Onboard a new library ([#9014](#9014)) ([b4cef83](b4cef83)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
2 participants
No description provided.