This repository was archived by the owner on Mar 26, 2026. It is now read-only.
test: Fix the reaper and simplify the instance and backup deletion - #1597
Merged
Conversation
product-auto-label
Bot
added
size: s
danieljbruce
changed the title
danieljbruce
changed the title
danieljbruce
marked this pull request as ready for review
April 22, 2025 16:51
cindy-peng
approved these changes
Apr 22, 2025
kevkim-codes
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While doing the Node 18 upgrade in #1582 the pqueue dependency was removed because it had some incompatibilities with Node 18. Some compiler/linter errors emerged that prevented the PR from being merged when the pqueue dependency was used.
When pqueue was removed it broke the reaper so now instances aren't getting deleted and we are running into quota issues when testing. This PR simplifies the reaper logic by just deleting the instances and backups one at a time without the pqueue dependency. It might take the test a little bit longer, but we will never run into dependency conflicts with pqueue again so it's well worth the tradeoff.