Skip to content

Conversation

@bashir2
Copy link
Member

@bashir2 bashir2 commented Mar 2, 2018

Tested: Ran manually and checked the new log message.

@coveralls
Copy link

coveralls commented Mar 2, 2018

Pull Request Test Coverage Report for Build 373

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 90.311%

Changes Missing Coverage Covered Lines Changed/Added Lines %
gcp_variant_transforms/vcf_to_bq.py 1 2 50.0%
Totals Coverage Status
Change from base Build 371: -0.02%
Covered Lines: 3076
Relevant Lines: 3406

💛 - Coveralls

@bashir2 bashir2 requested a review from allieychen March 2, 2018 19:26

def run(argv=None):
"""Runs VCF to BigQuery pipeline."""
if argv:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think you can combine this as logging.info('Command ...', ' '.join(argv or sys.argv))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bashir2 bashir2 merged commit 5b200f6 into googlegenomics:master Mar 2, 2018
@bashir2 bashir2 deleted the int_test branch March 2, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants