fix: rename InvalidatingComposeView getRotation param to avoid View shadowing - #952
Open
kikoso wants to merge 1 commit into
Open
fix: rename InvalidatingComposeView getRotation param to avoid View shadowing#952kikoso wants to merge 1 commit into
kikoso wants to merge 1 commit into
Conversation
…hadowing InvalidatingComposeView extends View, which already declares getRotation(): Float. The constructor property of the same name was silently shadowed by the inherited View method, so calling getRotation() inside Content() never invoked the injected lambda and the rotation LaunchedEffect key never reflected cluster/item rotation state changes.
Contributor
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidatingComposeViewextendsAbstractComposeView→View, which already declaresgetRotation(): Float. The constructor propertygetRotation: () -> Floatwas silently shadowed by the inheritedViewmethod, so callinggetRotation()inContent()resolved toView.getRotation()instead of invoking the injected lambda.rotationkey used in theLaunchedEffectthat triggers invalidation never reflected the actual cluster/item rotation state.getRotationOverrideto remove the ambiguity, matching howgetAnchor/getZIndexare already named without collision.Fixes #951
Test plan
./gradlew :maps-compose-utils:compileDebugKotlinpasses