Skip to content

fix: rename InvalidatingComposeView getRotation param to avoid View shadowing #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kikoso wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: rename InvalidatingComposeView getRotation param to avoid View shadowing #952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...compose-utils/src/main/java/com/google/maps/android/compose/clustering/ClusterRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ internal class ComposeUiClusterRenderer<T : ClusterItem>(
private fun createAndAddView(key: ViewKey<T>): ViewInfo {
val view = InvalidatingComposeView(
context,
getRotation = {
getRotationOverride = {
when (key) {
is ViewKey.Cluster -> clusterContentRotationState.value
is ViewKey.Item -> clusterItemContentRotationState.value
Expand Down Expand Up @@ -381,7 +381,7 @@ internal class ComposeUiClusterRenderer<T : ClusterItem>(
*/
private class InvalidatingComposeView(
context: Context,
private val getRotation: () -> Float,
private val getRotationOverride: () -> Float,
private val getAnchor: () -> Offset,
private val getZIndex: () -> Float,
private val content: @Composable () -> Unit,
Expand All @@ -392,7 +392,7 @@ internal class ComposeUiClusterRenderer<T : ClusterItem>(

@Composable
override fun Content() {
val rotation = getRotation()
val rotation = getRotationOverride()
val anchor = getAnchor()
val zIndex = getZIndex()
LaunchedEffect(properties.anchor, properties.zIndex, properties.rotation, rotation, anchor, zIndex) {
Expand Down
Loading