test(career): assert exact arena manifest mappings

[byrongamatos]

CodeRabbit follow-up on #961 — assert the complete loops/stingers/sfx objects instead of key/presence checks, so swapped media filenames fail the suite.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Strengthened validation of arena venue media manifests, including loop, stinger, and sound-effect filename mappings.
  • Continued verifying that all declared media files exist and contain data.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1a652a98-d863-4461-acd9-d071157b7d0c

📥 Commits

Reviewing files that changed from the base of the PR and between ea9da0a and 508aa76.

📒 Files selected for processing (1)

• tests/js/career_plugin.test.js

---

📝 Walkthrough

Walkthrough

The arena venue-pack integration test now asserts exact manifest mappings for loops, stingers, and up/down SFX while continuing to verify that referenced media files exist and are non-empty.

Changes

Arena manifest validation

Layer / File(s)	Summary
Validate arena media mappings tests/js/career_plugin.test.js	The test now checks exact loop, stinger, and SFX filename mappings in the arena manifest, alongside existing media file validation.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

• got-feedBack/feedBack#907: Added related career plugin venue-pack integration test coverage.
• got-feedBack/feedBack#927: Strengthened manifest mapping assertions for another venue pack.
• got-feedBack/feedBack#961: Added the arena manifest and its resource mappings.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is missing the required template sections for What, feedpak surface, and Checklist.	Rewrite the PR description using the repository template, including What, feedpak surface, and Checklist sections with the required details.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately describes the main change to arena manifest test assertions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/arena-manifest-exact

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

---

_{Comment @coderabbitai help to get the list of available commands.}