Bundle the AXA club venue pack (career stage 2)

[byrongamatos]

Stage 2 of the career (Velvet Room, 50★) now ships in every build: media at `plugins/career/venue-packs/club/`, served by the bundled-pack fallback. `venues.json` untouched.

Contents: 4 reactive loops (state-scaled stage washes over the AXA venue's own neon, 110-spectator crowd), 2 stingers, 7s balcony flyover intro past the dressed stage (piano/guitars/drums/LED walls). 2580×1080, largest file 80MB.

• Audio is dive-bar placeholder pending club-scale recordings (file swap, no re-render).
• Adds the club bundled-media test (exact manifest mappings, per the test(career): assert exact arena manifest mappings #962 pattern).
• Reworks `test_state_reports_installed_and_delete_removes`: with all three venues bundled, deleting a downloaded pack falls back to the bundled copy — the test now asserts that design instead of assuming club is uninstalled.
• Codex preflight unavailable (usage limit); suites green: 999/999 `node --test`, 42/42 career pytest.

With this merged, the full career arc — dive bar → AXA club → arena — is in every build.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Added the Club venue pack with complete intro, loop, stinger, and sound-effect media.
• Bug Fixes
  • Deleting a downloaded Club venue pack now preserves its installed status when bundled content remains.
  • Removed downloaded manifest files are now correctly reflected after deletion.
• Tests
  • Added coverage validating required Club media assets and pack metadata.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c7b31ba-cb0e-40f5-aa0f-e543ee7f5f30

📥 Commits

Reviewing files that changed from the base of the PR and between af61177 and 0bd3802.

⛔ Files ignored due to path filters (10)

• plugins/career/venue-packs/club/bored.mp4 is excluded by !**/*.mp4
• plugins/career/venue-packs/club/cheer.mp4 is excluded by !**/*.mp4
• plugins/career/venue-packs/club/clap.mp4 is excluded by !**/*.mp4
• plugins/career/venue-packs/club/club-ambience.mp3 is excluded by !**/*.mp3
• plugins/career/venue-packs/club/ecstatic.mp4 is excluded by !**/*.mp4
• plugins/career/venue-packs/club/engaged.mp4 is excluded by !**/*.mp4
• plugins/career/venue-packs/club/intro.mp4 is excluded by !**/*.mp4
• plugins/career/venue-packs/club/neutral.mp4 is excluded by !**/*.mp4
• plugins/career/venue-packs/club/sfx-down.mp3 is excluded by !**/*.mp3
• plugins/career/venue-packs/club/sfx-up.mp3 is excluded by !**/*.mp3

📒 Files selected for processing (3)

• plugins/career/venue-packs/club/manifest.json
• tests/js/career_plugin.test.js
• tests/plugins/career/test_routes.py

---

📝 Walkthrough

Walkthrough

Adds a club venue manifest with loop, stinger, intro, and SFX mappings. JavaScript tests validate the manifest and referenced media files, while route tests cover deletion of downloaded content when bundled content remains installed.

Changes

Club venue pack

Layer / File(s)	Summary
Define and validate club media pack plugins/career/venue-packs/club/manifest.json, tests/js/career_plugin.test.js	Defines the club asset mappings and verifies each referenced media file exists and is non-empty.
Verify bundled-pack deletion state tests/plugins/career/test_routes.py	Confirms downloaded manifest removal while bundled content keeps the venue marked as installed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• got-feedBack/feedBack#927: Introduces bundled venue-pack routing behavior covered by these deletion-state tests.
• got-feedBack/feedBack#961: Adds a similar venue manifest and media-file validation tests.
• got-feedBack/feedBack#962: Tightens exact venue manifest mapping assertions.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/bundle-club-pack

---

_{Comment @coderabbitai help to get the list of available commands.}