Skip to content

Conversation

@greggman
Copy link
Contributor

@greggman greggman commented May 2, 2025

  • webgpu:api,operation,command_buffer,image_copy:rowsPerImage_and_bytesPerRow
  • webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format
  • webgpu:api,validation,image_copy,layout_related:required_bytes_in_copy

They all had issues related to the maximum size they were allowed to test and/or the valid max dimension of a compressed texture.

Added getMaxValidTextureSizeForFormatAndDimension which returns the maxiumum valid size for the given format and dimension. In other words it will be the device limit rounded down by block size where appropriate.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

* webgpu:api,operation,command_buffer,image_copy:rowsPerImage_and_bytesPerRow
* webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format
* webgpu:api,validation,image_copy,layout_related:required_bytes_in_copy

They all had issues related to the maximum size they were allowed to test
and/or the valid max dimension of a compressed texture.

Added `getMaxValidTextureSizeForFormatAndDimension` which returns the
maxiumum valid size for the given format and dimension. In other words
it will be the device limit rounded down by block size where appropriate.

* gpuweb#4380
* gpuweb#4381
* gpuweb#4382
@greggman greggman requested a review from beaufortfrancois May 2, 2025 10:09
@greggman
Copy link
Contributor Author

greggman commented May 2, 2025

tested on a local build with 'texture-compression-astc-sliced-3d' enabled

Copy link
Collaborator

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried those locally as well and it works great! Thank you very much for unblocking https://chromium-review.googlesource.com/c/chromium/src/+/6470184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants