Tasks with input files marked 'skip when empty' should delete outputs only when it is known to be safe to do so

[adammurdoch]

Currently, the outputs for these tasks are deleted when all source is removed, regardless of whether this is the desired outcome or not. Instead, we should delete these files only when we know this is what the user wants, consistent with whatever we come up with for cleaning up stale files more generally.

Expected Behavior

Current Behavior

Context

Steps to Reproduce (for bugs)

Your Environment

• Build scan URL:

[eriwen]

From #1012

Expected Behavior

When using the exclude method and actually all files from sourceDir are excluded, the destination dir should remain unchanged

Current Behavior

When using the exclude method and actually all files from sourceDir are excluded,
Then ALL the ecluded files that are already present in the DestinationDir are DELETED

Steps to Reproduce (for bugs)

e.g. in my file system:

• sourceDir with several (and only! ) *.sql files
• destDir with the same files copied from sourceDir

then executing the following task

task testBBLCopy (type: Copy) {
	from sourceDir
	//exclude { details -> true }
	exclude '**/*.sql'
	into destDir
	includeEmptyDirs = false
}

Your Environment

Mac OS X ElCapitan 10.11.6
Gradle Distribution: Gradle wrapper from target build
Gradle Version: 3.2
Java Home: /Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk/Contents/Home
JVM Arguments: None
Program Arguments: None
Gradle Tasks: testBBLCopy

[wolfs]

@ danreb25 Could you elaborate why that is a problem for you? Do you have other copy tasks copying into the same destination directory? Where does your destination directory reside? Inside the build directory?
Doesn't executing the copy task after a clean have the same end result as deleting all the files in the destination directory when there is nothing to copy (i.e. the destination directory is empty)?

[danreb25]

Hi wolfs sorry for the delay,

*why that is a problem for you?

I expect the Copy task to copy files from sourceDir to destinationDir and not to "SYNC"
my destinationDir with the sourceDir. I would use the Syn Task for this.

here under a testCase to reproduce/illustrate the problem

Action on fileSystem	GradleTask runned		Origin Dir	Destination dir
initial state	null	-->	[tex1.txt;tex2.txt;tex3.txt]	✅[text4.txt]
null	myCopyTask	-->	[tex1.txt;tex2.txt;tex3.txt]	✅[text4.txt;tex1.txt;tex2.txt;tex3.txt]
rm from OriginDir tex1.txt;tex2.txt	null	-->	[tex3.txt]	✅[text4.txt;tex1.txt;tex2.txt;tex3.txt]
null	myCopyTask	-->	[tex3.txt]	✅[text4.txt;tex1.txt;tex2.txt;tex3.txt]
null	myCopyTask (rerunned)	-->	[tex3.txt]	✅[text4.txt;tex1.txt;tex2.txt;tex3.txt]
rm from OriginDir tex3.txt	null	-->	[-]	✅ [text4.txt;tex1.txt;tex2.txt;tex3.txt]
null	myCopyTask	-->	[-]	🔴 [text4.txt]

in breaf when there is nothing in the filtered files in OriginDir all the previous copied files (and only those copied sith the gradle task) are deleted.

With Gradle 3.1 when running the step 3 the task was considered up-to-date and the file wasn't deleted in the destinationDir

The problem exists since gradle 3.2> (tested also on 3.3)

*Do you have other copy tasks copying into the same destination directory?
yes
*Where does your destination directory reside?
Outside the build directory
*Doesn't executing the copy task after a clean have the same end result as deleting all the files in the destination directory when there is nothing to copy (i.e. the destination directory is empty)?
I still need to test this one more in depth