Expose Wrapped dataFetcher #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gipeshka
reviewed
Aug 20, 2018
| result | ||
| } else { | ||
| val wrapper = options | ||
| .genericWrappers |
Contributor
There was a problem hiding this comment.
should cs fixes be included in feature pr?
Author
There was a problem hiding this comment.
Im using intellij and when I push it fixes lines automatically.
It's only cs fixes, so it doesn't matter
Contributor
There was a problem hiding this comment.
Well, that actually matters because
- it makes PR more lines to read
- the PR affects lines that have nothing to do with the feature, meaning it's more difficult to find why/when the initial fix was made
Just saying, no cs configuration is included in the project anyway.
Author
There was a problem hiding this comment.
Ok. so I won't do it next time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving #164