v6: adjust MessageProcessor schema line assertions - #4459
Merged
Conversation
The `Test` type in the generated schema grew by three lines once the `json` custom-scalar field from #4448 landed alongside the query builder fields already on this branch, so the type definition ranges shifted. Only the expected line numbers change, exactly as the note above these assertions anticipates. This only shows up on `graphiql-6`: the test passes on `main`, where the query builder fields are absent.
|
trevor-scheer
marked this pull request as ready for review
August 7, 2026 04:23
trevor-scheer
enabled auto-merge (squash)
August 7, 2026 04:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MessageProcessor.spec.tsasserts the definition ranges of a type in the generated schema by absolute line number. TheTesttype grew by three lines when thejsoncustom-scalar field from #4448 merged in frommainand landed alongside the query builder fields already on this branch. This updates the expected line numbers.Test plan
yarn testpasses forgraphql-language-service-server(9 files, 116 passing, 1 skipped)