polish(introspection): cover __Type.description on wrapping types - #4844
Open
vrana055 wants to merge 1 commit into
Open
polish(introspection): cover __Type.description on wrapping types#4844vrana055 wants to merge 1 commit into
vrana055 wants to merge 1 commit into
Conversation
|
|
|
@vrana055 is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
vrana055
changed the title
Adds a test asserting __Type.description resolves to null for LIST and NON_NULL wrapping types, which have no description of their own, while ofType.description still resolves. getIntrospectionQuery() never hit this branch: it asks for description only on named types and for kind/name on ofType. This was the last uncovered branch in the resolver, so the `node:coverage ignore` pragma and its FIXME are removed. Coverage stays at 100% without them.
vrana055
force-pushed
the
test/introspection-description-coverage
branch
from
August 8, 2026 05:52
59988e2 to
2dfd614
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test asserting __Type.description resolves to null for LIST and NON_NULL wrapping types, which have no description of their own, while ofType.description still resolves. getIntrospectionQuery() never hit this branch: it asks for description only on named types and for kind/name on ofType.
This was the last uncovered branch in the resolver, so the
node:coverage ignorepragma and its FIXME are removed. Coverage stays at 100% without them.