Skip to content

feat(design): automatically add anchor link and copy URL button to article headings - #4260

Merged
damienwebdev merged 11 commits into
graycoreio:developfrom
joannalauu:feat/heading-anchors
Jan 6, 2026
Merged

feat(design): automatically add anchor link and copy URL button to article headings#4260
damienwebdev merged 11 commits into
graycoreio:developfrom
joannalauu:feat/heading-anchors

Conversation

@joannalauu

@joannalauu joannalauu commented Dec 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Fixes: #3973

New behavior

  • Added anchor link to article heading that directs user to that heading on click.
  • Added button next to article heading that copies the heading URL to clipboard on click
  • Anchor links and buttons are automatically added to all <h2>, <h3>, <h4> headings in DaffArticleComponent by default, but can be removed by adding a nolink attribute into the element

Breaking change?

  • Yes
  • No

Additional context

@joannalauu
joannalauu requested review from a team as code owners December 14, 2025 02:11
xelaint
xelaint requested changes Dec 17, 2025
View reviewed changes
Comment thread libs/design/article/src/article-heading-link/heading-link/heading-link.component.html Outdated
Comment thread libs/design/article/src/article-heading-link/heading-link/heading-link.component.html Outdated
Comment thread libs/design/article/src/article-heading-link/heading-link/heading-link.component.html Outdated
Comment thread libs/design/article/src/article-heading-link/heading-link/heading-link.component.scss Outdated
Comment thread libs/design/article/src/article-heading-link/heading-link/heading-link.component.scss Outdated
Comment thread libs/design/article/src/article-heading-link/heading-link/heading-link.component.scss Outdated
Comment thread libs/design/article/src/article-heading-link/heading-link/heading-link.component.html Outdated
Comment thread libs/design/article/src/article-heading-link/heading-link/heading-link.component.html Outdated
Comment thread libs/design/article/src/article-theme.scss Outdated
@xelaint
xelaint requested a review from damienwebdev December 17, 2025 19:57
@xelaint xelaint added the package: design @daffodil/design label Dec 17, 2025
@joannalauu
joannalauu requested a review from xelaint December 17, 2025 20:47
damienwebdev
damienwebdev requested changes Dec 30, 2025
View reviewed changes
Comment thread libs/design/article/src/article-heading-link/service/heading-link.service.ts
xelaint
xelaint requested changes Dec 30, 2025
View reviewed changes
Comment thread libs/design/article/src/article-heading-link/heading-link/heading-link.component.scss
joannalauu and others added 11 commits December 30, 2025 19:18
@joannalauu
feat(design): implemented heading link component in @daffodil/design
b27b180 
- fully completed component design
- implemented copy link to clipboard functionality, but currently coping inaccurate full url
- have not tried to remove `DaffioDocsHeadingLinkComponent` from daffio
@joannalauu
feat(design): full url path to fragment is copied to clipboard by cli…
5c7cca5 
…cking on icon
@joannalauu
refactor(daffio): removed all code implemented in #3897
e4721a9 
-  `DaffioDocsHeadingLinkComponent` from `#3897` is now replaced by `DaffArticleHeadingLinkComponent`
@joannalauu
test(design): add spec tests for DaffArticleHeadingLinkComponent an…
44df223 
…d `DaffArticleHeadingLinkService`
@joannalauu
feat: don't add link to heading if nolink attribute is present
00dafaa
@joannalauu
docs: update readme
554459c
@joannalauu
feat(design-examples): update article-headings examples
a489902
@joannalauu
fix: error with html tags in readme
416f085
@joannalauu
implement requested changes
0eb7b39
@joannalauu
add gap to heading-link styles
f1b3159
@joannalauu
skip headings in article encapsulated components
15ae60c
damienwebdev
damienwebdev approved these changes Jan 6, 2026
View reviewed changes

@damienwebdev damienwebdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev
damienwebdev merged commit 39cfdd4 into graycoreio:develop Jan 6, 2026
16 checks passed
@gray-bot gray-bot mentioned this pull request Jan 6, 2026
Merged
@joannalauu
joannalauu deleted the feat/heading-anchors branch January 6, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damienwebdev damienwebdev damienwebdev approved these changes
@xelaint xelaint xelaint approved these changes

Assignees

No one assigned

Labels

package: design @daffodil/design

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add anchor links to markdown titles from <h2> to <h4>

3 participants

@joannalauu @damienwebdev @xelaint